Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): fix urls of README(#522) #523

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

error0g
Copy link
Contributor

@error0g error0g commented Sep 20, 2022

Summary about this PR

Issue Number: close #522

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2022

CLA assistant check
All committers have signed the CLA.

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2022

This pull request's title should follow requirements next. @error0g please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-docs docs for pull request label Sep 20, 2022
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hustjieke
Copy link
Collaborator

Nice job!
Thanks for you contribution!
@error0g

@Nliver Nliver removed the request for review from RingsC September 20, 2022 12:09
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good job!

README_zh-hans.md Outdated Show resolved Hide resolved
README_zh-hans.md Outdated Show resolved Hide resolved
README_zh-hans.md Outdated Show resolved Hide resolved
@Nliver Nliver changed the title docs(README): fix urls (#522) docs(README): fix urls of README.md(#522) Sep 21, 2022
@Nliver Nliver changed the title docs(README): fix urls of README.md(#522) docs(README): fix urls of README(#522) Sep 21, 2022
@RingsC RingsC merged commit 5ecf786 into stoneatom:stonedb-5.7-dev Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-docs docs for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Correct some url errors
5 participants